Refactor windows stuff #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosracd
force-pushed
the
refactor/windows
branch
2 times, most recently
from
11ba3c7 to
f3354c1
Compare
ihilt
approved these changes
Dec 23, 2024
include shell commands to make it easier to install the correct dependencies make a note about Java remove restriction on installing LCM before using it; that's no longer necessary since statically linking more stuff
nosracd
force-pushed
the
refactor/windows
branch
from
f3354c1 to
61d154e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #547 (based off of its branch). This PR:
-DPython_FIND_REGISTRY=NEVER(doesn't seem to be necessary currently, although I kept the advice inWinSpecific/README.md). I'd be fine with keeping it around as a guard though.TemporaryDirectoryrather thanNamedTemporaryFile(it was creating a file then overwriting it, which resulted in permissions errors on Windows)WinSpecific/README.mdto give some shell commands for installing LCM's dependencies in an MSYS environment. It seems that is a common source of issues, so hopefully this makes it easier to get started.