Updates to the Motor Drive Package #4103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hermoFluid/package.oder
…lanced/Loads/Examples/MotorDrive/InductionMotors/BaseClasses directory
…lanced/Loads/Examples/MotorDrive/InductionMotors/Examples directory
…lanced/Loads/Examples/MotorDrive directory
…lanced/Loads/MotorDrive/Coupled/Examples directory
JayHuLBL
reviewed
Jan 27, 2025
| "Specific heat capacity of medium 2 at default medium state"; | ||
|
|
||
| equation | ||
| chi.P = tauChi*Buildings.Utilities.Math.Functions.smoothMax(spe.w,1e-6,1e-8); |
There was a problem hiding this comment.
@ViswanathanGanesh01 Can we create a base class in the package ThermoFluid, to do the calculation? The base class would have inputs P, and w, output tau, and parameter for the 1e-6 and 1e-8.
This will avoid missing the equations and connections in the equation section, and avoid repeat the pattern among Chiller, HeatPump, and Pump.
There was a problem hiding this comment.
Included a baseclass function.
JayHuLBL
reviewed
Jan 27, 2025
| annotation (Placement(transformation(extent={{66,28},{86,48}}))); | ||
| equation | ||
| // Assign values for motor model calculation from electrical interface | ||
| theta_s = PhaseSystem.thetaRef(terminal.theta) "phase angle"; |
There was a problem hiding this comment.
is it possible to create base class to do the calculations as showing in these equations? it seems that we have same pattern as in the SquirrelCageDrive?
JayHuLBL
reviewed
Jan 27, 2025
| "Mechanical connector" | ||
| annotation (Placement(transformation(extent={{90,-10},{110,10}}))); | ||
|
|
||
| BaseClasses.MotorMachineInterface torSpe( |
There was a problem hiding this comment.
Check the missing comments. All the instances should have the comment.
There was a problem hiding this comment.
Included comments for all instances.
JayHuLBL
reviewed
Jan 27, 2025
| @@ -0,0 +1,185 @@ | |||
| within Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.BaseClasses; | |||
| model MotorModel1 | |||
There was a problem hiding this comment.
Do we still need this class?
There was a problem hiding this comment.
No Dr. Hu. I have removed the class and updated the package.order
JayHuLBL
reviewed
Jan 27, 2025
| points={{60,0},{100,0}}, | ||
| color={0,0,127}, | ||
| thickness=1)); | ||
| annotation (Icon(coordinateSystem(preserveAspectRatio=true, extent={{-60, |
There was a problem hiding this comment.
check the icon layer diagram. The connectors are in wrong position.
There was a problem hiding this comment.
Updated the Icon Layer and connectors to be aligned,
JayHuLBL
reviewed
Jan 27, 2025
| @@ -0,0 +1,193 @@ | |||
| within Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.BaseClasses; | |||
| model MotorModel | |||
There was a problem hiding this comment.
Add comments to the class and all the instances.
There was a problem hiding this comment.
Included Comments to the class and all instances.
JayHuLBL
reviewed
Jan 27, 2025
| 91.35,90},{91.35,89.9},{88.7,89.9}}, color={0,0,127})); | ||
| connect(v_qs, i_qs_block.v_qs) | ||
| annotation (Line(points={{-160,100},{64,100},{64,99.8}}, color={0,0,127})); | ||
| annotation ( |
There was a problem hiding this comment.
Add the class documentation.
There was a problem hiding this comment.
Added Documentation
JayHuLBL
requested changes
Jan 27, 2025
There was a problem hiding this comment.
@ViswanathanGanesh01 Please see inline comments.
- avoid mixing the equations and connections. You may create base classes.
- check if all the instances have comment.
- check if all the class have the documentation. Please make sure each class has a description comment.
- add documentation to each
package.mofile.
…nductionMotors/BaseClasses/MotorModel1.mo Duplicate file.
Removed MotorModel1
|
Run the unittest with Optimica. We can following warnings: It seems that there are some self-connecting connector. Please double check the models and the instanced classes. |
…nductionMotors/BaseClasses/computeElectricalParameters.bak-mo
…hermoFluid/BaseClasses.mo
|
@ViswanathanGanesh01 Please let me know when it is ready for review. |
|
@JayHuLBL Hello Dr. hu, the package is ready for review. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated package includes