Templates • HW plant #3364
Draft
Templates • HW plant #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration is not supported by G36. And the model now fails to simulate with OCT and Dymola.
…ldings into issue3266_template_HW_plant
…ldings into issue3266_template_HW_plant
…ssue1374_templates
…ldings into issue3266_template_HW_plant
Otherwise the file paths are used to compute the total checksum. So the total checksum will differ on another server.
- This allows using parameters in binding equations, such as the number of units.
- Validation model runs w/ modulating CW isolation valves only
… dp parameterization
…ssue1374_template_CHW_final
…elica-buildings into issue3266_template_HW_plant
AntoineGautier
force-pushed
the
issue3266_template_HW_plant
branch
from
9f02685 to
e73bafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall NOT be merged before #2700 is merged.
This will close #3266.
This is a DRAFT PR to test the new CI workflow for the Templates package (see
Buildings/Resources/Scripts/travis/templates/checkandrun.sh) and start the review process.TODO before merging:
issue2180_BoilerPlant_MainController_oct_2021is merged into the master, replaceTemplates.HeatingPlants.HotWater.Components.Controls.Guideline36Pluginwith the actual controller. (The branchissue3266_template_HW_planthas no dependency toissue2180_BoilerPlant_MainController_oct_2021and uses a "temporary" class that is plug compatible with the current version of the controller from commit 1a5959f.)Buildings/Resources/Scripts/travis/templates/BoilerPlant.pyand.travis.yml.finalin the binding offuefor records withinBuildings.Fluid.Boilers.Data.LochinvarNote that the template models are currently not supported by Dymola due to a bug in handling arrays of record. Tickets #SR01004314-01 #SR01022035-01 and #SR00955379-01 are in status "Wait for Correction Delivery" or "R&D Handling" at DS.