Feature/next plugin storybook #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node version should be 14, otherwise, next/image fails to load static file images located in public dir detail: https://stackoverflow.com/questions/67641673/next-js-app-running-inside-a-docker-container-fails-to-load-static-file-images
* Set default webpack publicPath value to override auto * Add test case * update size-test
Makes sure a helpful error is shown for `<Link>` with multiple children ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Tim Neutkens <[email protected]>
* Ensure rewrites are resolved correctly through history * update test
…vercel#25495) * Fix rewrite and dynamic params * set _shouldResolveHref to true when initializing client state * add window.beforeNav check * fix broken path * fix build-output tests * remove yarn.lock changes
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Remove deprecated features In the next major version we'll want to merge this PR that removes some of the long-time deprecated features, it'll have a positive effect on bundle size. * Update tests * Update tests * Change unsized to layout=fill in test * Update sizes * Update rotation test * Update size limit test * Update test * Update test * Update test
- Fixed the missing prop `components` to `<MDXRemote/>`. - Added a `defaultComponents` and `source` mdx to provide more clarity on the example. ## Documentation / Examples - [x] Make sure the linting passes
Bump up electron of an example, `with-electron-typescript` adding `contextIsolation`, https://www.electronjs.org/docs/tutorial/context-isolation#context-isolation.
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
* Remove experimental tag from Script component * update size tests * Update size * Update size limit * Update basic output sizes Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: Tim Neutkens <[email protected]>
Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: Tim Neutkens <[email protected]>
1. Stable version of TypeScript 4.3 just released, replaced beta version tag with stable version v4.3.2. 2. Add reference article explaining about the performance improvement. ## Documentation / Examples - [x] Make sure the linting passes
* Bump "engines" to node >= 12.0.0 * Bump next-stats-action * Rename azure groups
…xt.js (vercel#25581) remove `alwaysStrict: true` rule from tsconfig.json in with-typescript example, because the rule is included in `strict: true` has been already written in tsconfig.json and other included rules such as `noImplicitAny: true` have not been written. [tsconfig documentation link](https://www.typescriptlang.org/tsconfig#alwaysStrict) ## Documentation / Examples - [x] Make sure the linting passes
Co-authored-by: Steven <[email protected]> Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: Tim Neutkens <[email protected]>
vercel#25775) ## Feature - [ ] Telemetry added. In case of a feature if it's used or not. ### Replace 'require' with 'import' in bench files Node.js 12 allows you to use `import`. ### Update dependancies https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md#breaking-changes > Require Node.js v12+ For vercel#25761, Node.js 12 is required. Therefore, there is no problem updating it. For benchmarking purposes, it would be reasonable to update to the latest version.
It appears this library isn't maintained, plus there's already the other `with-relay-modern` example. relay-tools/react-relay-network-modern#128
Some slight tweaks based on my review of the docs. A few outstanding questions left 😄 vercel#25064 (review)
…5589) ## What   ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Documentation / Examples - [x] Make sure the linting passes
Hey guys! Some time ago I used the `with-grommet` example to start a project and I ran into some issues because of the styled-components version. I tried to use some new features and it didn't work as I expected, then I noticed the styled-component version was the `v4`. When I bumped the version it started to work. I am bumping all the styled-components versions on examples because some people may run into the same issue. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [x] Make sure the linting passes
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
…25797) Co-authored-by: Steven <[email protected]> Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Gerald Monaco <[email protected]>
Fixes an issue where "env" would be ignored and would crash if there was no top level "presets". Also found that webpack did not invalidate the cache on changes to the babel config, so I also fixed that.
Signed-off-by: Matthew Gleich <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Tim Neutkens <[email protected]>
* Enable webpack 5 by default for all apps Still provides a way to opt-out using `webpack5: false` in next.config.js. Also throws an error for `future.webpack5`. * Update tests * Update test to run on webpack 4 instead of webpack 5 * disable webpack5 for legacy tests * Fix stats-config for webpack4 * update tests * update size for webpack4 test * move basic suite first * update basic test * Add logs * remove outdated testFutureDependencies job Co-authored-by: JJ Kasper <[email protected]>
## Documentation / Examples - [x] Make sure the linting passes ### Deployed with Cloud Run Button <img width="1075" alt="Screen Shot 2021-06-06 at 10 22 51 pm" src="https://user-images.githubusercontent.com/170554/120924210-d7946780-c715-11eb-889e-79679f795c54.png"> ### Next.js working on Google Cloud Run <img width="982" alt="Screen Shot 2021-06-06 at 10 23 10 pm" src="https://user-images.githubusercontent.com/170554/120924229-e418c000-c715-11eb-9aca-569923f7306d.png">
createContext() no longer accepts initialState as parameter ## Documentation / Examples - [x] Make sure the linting passes
If you give a Static Image to the Image component, TypeScript will throw a type error. This Pull Request fixes it. ## Bug - ~~Related issues linked using `fixes #number`~~ - [x] Integration tests added ## ~~Feature~~ - ~~Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.~~ - ~~Related issues linked using `fixes #number`~~ - ~~Integration tests added~~ - ~~Documentation added~~ - ~~Telemetry added. In case of a feature if it's used or not.~~ ## ~~Documentation / Examples~~ - ~~Make sure the linting passes~~ --- follow-up vercel#24993 cc @atcastle
As mentioned in vercel#25854 `witn-next-sitemap` example is missing `typescript` package as a dependency - [x] Make sure the linting passes
This PR fixed command in upgrade guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.