Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic clustering #33

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

generic clustering #33

wants to merge 14 commits into from

Conversation

erik-romson
Copy link

Hi
I found your library interesting but I needed to cluster based on objects, not strings. see src/test/java/com/apporiented/algorithm/clustering/ClusterPersonTest.java for an example.

So I rewrote it to handle generics and added some streaming as well (a few more dependencies but only in test scope).

I realize that this is a big change (code wise anyway), so I'll stop here. If you are interested to merge, let me know and I'll clean it up and do whatever you want me to fix

@lbehnke
Copy link
Owner

lbehnke commented Dec 13, 2019

Thanks for this contribution. It certainly makes sense to use generic cluster nodes and I'd like to merge it. So if you could resolve the merge conflicts and clean up the code that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants