feat(world): strip world prefix from function names when encoding system calls #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e1a0ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
frolic
commented
Jan 29, 2025
| /** | ||
| * System function name to call | ||
| */ | ||
| readonly functionName: functionName; |
There was a problem hiding this comment.
pulled these out for stronger types in the function body and so we can add TSDoc to clarify the abi param
frolic
commented
Jan 29, 2025
| import { Hex } from "viem"; | ||
|
|
||
| /** @internal */ | ||
| export function internal_normalizeSystemFunctionName(systemId: Hex, functionName: string) { |
There was a problem hiding this comment.
I don't wanna propagate the usage of this so I prefixed this with internal_ to make it clear we shouldn't export this
alvrs
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2463