-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(world): add CallWithSignatureSystem #3496
base: main
Are you sure you want to change the base?
Conversation
|
@@ -0,0 +1,174 @@ | |||
// SPDX-License-Identifier: MIT | |||
// OpenZeppelin Contracts (last updated v5.0.0) (utils/cryptography/ECDSA.sol) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we decide it was better to copy/paste these here instead of importing from OZ as a dep?
if we keep this here, maybe should put these in a vendor
or similar directory to better isolate unchanged and already audited copy/pasted source files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original reason was that the OZ package was a pretty heavy dependency and we only needed very few files from it. At this point we do have a couple vendored OZ files in the world package (ERC165Checker
, IERC1967
, Proxy
, StorageSlot
) but I don't think it's worth changing our approach now. MUD is audited as a whole and the auditors can easily check that the files match the original sources. Changing paths of a Solidity package is always annoying because it would break things downstream if the files are imported since there are no explicit exports/remappings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope no one has imported these directly 🙈 wonder if we should start putting not-for-external-use source files into internal
dirs, like we've started doing for TS exports
...ages/world/src/modules/init/implementations/CallWithSignatureSystem/getSignedMessageHash.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Ingersoll <[email protected]>
closes #3437