chore: standardise workspace dependencies

[JamesLefrere]

Fixes #2962

• Replace common workspace package devDependencies (where possible without major modifications) with the workspace root's devDependencies
• Update some error message snapshots for workspace vitest version
• Caveats:
  • execa wasn't updated to the workspace version in all cases, because there are some breaking changes going from 6/7 to 9
  • Some optional peer dependencies have version mismatches still. The React hooks tests just need an update from the discontinued react-hooks-testing-library.
  • There are two versions of forge-std in use still; unclear why these were chosen, so I didn't change them
  • No packages were added to the devDeps, but they are used a lot (e.g. solhint). It probably makes sense to add more, but this is a large PR already.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 27ca5d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[holic]

when publishing, do these version wildcards get swapped for the workspace semver?

[JamesLefrere]

Great point...from my testing, no they don't 😭

Seems like this a non-starter for mud in that case, we can't run this PR as-is.

Some possible paths:

1. Version 10 of pnpm introduces Catalogs. I just tried this locally and it works as intended; define catalog versions in pnpm-workspace.yaml, specify catalog: in workspace packages, and then packing/publishing any workspace package will set its version directly in the resulting package.json. We could try an upgrade (separate PR) then change this to use catalogs.
2. Use a tool like syncpack to manage workspace package versions.

Not sure what your plans are for v10 at the moment (release notes here). Sounds... maybe doable?

[holic]

I recently got rid of our usage of catalogs as it made some other things harder to work with: #3405

I have already made a habit of trying to keep versions aligned across the repo. It's not perfect, but hasn't been a huge issue.

The issue you're trying to solve (#2962) is specifically for common dev deps, so we can still move those up to the workspace root (and no need to declare them in each individual package's dev deps).

[JamesLefrere]

Got it, shame. Ok then, I'll just simply remove the wildcards from all dependencies in workspace packages, leave the wildcards for devDependencies, and that should do the trick.

[holic]

IMO we should lift the common dev deps into the workspace root's dev deps, and remove them from each package, rather than a wildcard

[JamesLefrere]

Before:

Packages: +2285
...
1.7G    node_modules

After:

Packages: +2157
...
1.5G    node_modules