Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[editor] Audio Output Renderer #834

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[editor] Audio Output Renderer #834

merged 1 commit into from
Jan 10, 2024

Conversation

rholinshead
Copy link
Contributor

@rholinshead rholinshead commented Jan 9, 2024 •
edited by rossdanlm
Loading

[editor] Audio Output Renderer

This is basically a copy/paste from workbook audio outputs in lastmile, so it should work the same.

See the PR summary from #854 to see test output example

@rholinshead rholinshead marked this pull request as ready for review January 9, 2024 23:47
@rholinshead
Copy link
Contributor Author

Me to this renderer:

@rholinshead rholinshead merged commit 21c1f86 into main Jan 10, 2024
1 check passed
@rossdanlm rossdanlm deleted the pr834 branch January 10, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saqadri saqadri saqadri approved these changes

@suyoglastmileai suyoglastmileai Awaiting requested review from suyoglastmileai

@Ankush-lastmile Ankush-lastmile Awaiting requested review from Ankush-lastmile Ankush-lastmile is a code owner

@jonathanlastmileai jonathanlastmileai Awaiting requested review from jonathanlastmileai

@rossdanlm rossdanlm Awaiting requested review from rossdanlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rholinshead @saqadri