Styling changes for Gradio Workbook #827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossdanlm
reviewed
Jan 9, 2024
Comment on lines
+5
to
+6
| name = "python-aiconfig-test" | ||
| version = "1.1.25" |
There was a problem hiding this comment.
For future, we don't need to keep changing this. We can have two separate repos and simply when we do pip install we explicitly pull from our test repo:
pip3 install --index-url https://test.pypi.org/project/python-aiconfig-test/
^We can use python-aiconfig instead of python-aiconfig-test
I supposed if we are going to update the the version number to match pytest anyways, it's not that much different to change package name so that's fine too
cc @jonathanlastmileai
rossdanlm
reviewed
Jan 9, 2024
|
|
||
| # If you want to upload to prod , run pypipublish.sh. | ||
|
|
||
| python3 -m twine upload --repository testpypi dist/* |
There was a problem hiding this comment.
cc @jonathanlastmileai can you change your PR from "draft" in #807 so we can land and keep changes separate here?
|
@saqadri can you post a video or screenshots of the editor? |
Created with `yo code`: https://code.visualstudio.com/api/get-started/your-first-extension
Successfully loads the local editor as a VSCode webview
Now that our actual local-editor works, no need to use the sample webview-ui to test the extension
Get the aiconfig from the VSCode textdocument: * The extension sends an `update` request to the webview when the TextDocument changes. * The webview handles that by updating the state of the AIConfig, which will trigger a re-render.
Delete an older experiment of a vscode extension. Main difference about this is it uses webpack for the build step but that's most likely unnecessary for our case.
Update content security policy to allow external images to render
Plus publish script for test-pypi
This was referenced Jan 12, 2024
Closed
This was referenced Jan 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styling changes for Gradio Workbook
Plus publish script for test-pypi
Stack created with Sapling. Best reviewed with ReviewStack.