Update aiconfig-editor for Delete Output #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan:
rholinshead
requested review from
saqadri,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
|
|
||
| if (vscode) { | ||
| notifyDocumentDirty(vscode); | ||
| } |
There was a problem hiding this comment.
are all the api calls notifying document dirty?
There was a problem hiding this comment.
Anything that modifies the aiconfig state (so, excludes api calls like list_models)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update aiconfig-editor for Delete Output
Summary: Bump
aiconfig-editorpackage to include the UI for deleting single output. Connect the callback in VSCodeEditor. Also, updated deleteModelSettings callback to properly notify document changeTest Plan: Tested deleting output (and global model settings) and seeing the change reflected in the config