Skip to content

Commit

Permalink
[editor][easy] Remove Confusing 'No Settings Available' Text for Miss…
Browse files Browse the repository at this point in the history
…ing Settings Property Renderer (#713)

# [editor][easy] Remove Confusing 'No Settings Available' Text for
Missing Settings Property Renderer

It's confusing to have the 'No settings available' text when there's no
renderer available for the type. Instead, just skip renderer for the
property for now. We'll add a JSON editor toggle to the settings drawer
to allow editing any settings, though it won't benefit from a schema
since the prompt schema is not direct 1:1 with JSON schema.

## Before:
![Screenshot 2024-01-02 at 3 13 36
PM](https://github.com/lastmile-ai/aiconfig/assets/5060851/59fb39da-4561-4064-856f-0f346cedf8e4)


## After:
![Screenshot 2024-01-02 at 3 13 20
PM](https://github.com/lastmile-ai/aiconfig/assets/5060851/144c4a96-b009-4f53-84eb-1a9c72805eee)
  • Loading branch information
rholinshead authored Jan 2, 2024
2 parents 811046e + 30e9b90 commit cec0103
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -419,5 +419,5 @@ export default function SettingsPropertyRenderer({
}

// TODO: Support toggling to monaco JSON editor at top level
return propertyControl ?? <Text>No settings available</Text>;
return propertyControl ?? null;
}

0 comments on commit cec0103

Please sign in to comment.