Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the language code to iTunes search api to get localized release notes #351

Closed
wants to merge 0 commits into from

Conversation

Add00w
Copy link
Contributor

@Add00w Add00w commented Nov 7, 2023

fixes #314

@larryaasen
Copy link
Owner

@Add00w Thanks for this pull request. Did you see that the unit tests are not passing?

@larryaasen larryaasen self-requested a review November 30, 2023 13:16
@larryaasen larryaasen added enhancement New feature or request need more information Further information is requested labels Nov 30, 2023
@Add00w
Copy link
Contributor Author

Add00w commented Dec 4, 2023

@Add00w Thanks for this pull request. Did you see that the unit tests are not passing?

Yes, I will fix

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8f9cad) 90.15% compared to head (c58a6e6) 90.27%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   90.15%   90.27%   +0.12%     
==========================================
  Files          11       11              
  Lines        1066     1080      +14     
==========================================
+ Hits          961      975      +14     
  Misses        105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larryaasen larryaasen added this to the 9.1.0 milestone Dec 29, 2023
@larryaasen
Copy link
Owner

@Add00w I would like to get this PR merged, but it now has a merge conflict. Can you resolve that?

@ibraheemalayan
Copy link
Contributor

@Add00w
@larryaasen

I solved the merge conflicts and did the changes required to be compatible with version 10.3.0 in PR #439
It has passed all the tests and is ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need more information Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

languageCode doesnt override the default one
3 participants