add multi-owner cw-ownable with cosmwasm v2
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…singleton. But can be re-use e.g. by defining `CREATOR: OwnershipStore = OwnershipStore::new("creator")`
* move all logic to `OwnershipStore`. This way `cw-ownable` is still a singleton. But can be re-use e.g. by defining `CREATOR: OwnershipStore = OwnershipStore::new("creator")`
* cargo fmt
* cargo clippy --tests
* use api and storage (instead of DepsMut) for being less restrictive
* fix ownable
* remove unneccessary lifetime (clippy warning)
---------
Co-authored-by: mr-t <[email protected]>
CyberHoward
requested changes
Aug 13, 2024
That all makes sense to me. I'm not too familiar with the context and overall architecture of this whole thing; my main goal here is to enable the cw-nfts cosmwasm v2 upgrade (public-awesome/cw-nfts#172) and I don't expect any of those edits would be an issue for it, maybe some minor changes. |
* update ownable exports and revert API breaking change * fully revert update_ownership breaking API change and fix relevant tests
CyberHoward
approved these changes
Aug 14, 2024
|
Thanks for contributing! I exported the Item's key so you can still construct the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes work by @taitruong from #21
cw-ownable(Multiple ownership public-awesome/cw-plus-plus#1)cw-ownablefor CosmWasm v2 compatibilityUnblocks public-awesome/cw-nfts#160 and indirectly DA0-DA0/dao-contracts#840