bug: mockery not setup correctly #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a subtle bug in the way Mockery is setup in the project, versions of Mockery before version 1.0.0 would automatically register a listener with PHPUnit meaning that assertions in mockery would automatically count towards PHPUnit's assertion count. This results in devs adding hacks to make the unit tests pass i.e adding the `DoesNotPerformAssertions` attribute. https://docs.mockery.io/en/latest/reference/phpunit_integration.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a subtle bug in the way Mockery is setup in the project, versions of Mockery before version 1.0.0 would automatically register a listener with PHPUnit meaning that assertions in mockery would automatically count towards PHPUnit's assertion count.
This results in devs adding hacks to make the unit tests pass i.e adding the
DoesNotPerformAssertionsattribute. currently two unit tests are affected by this.PHPUnit Integration
The benefit to the end user is building trust and confidence in the test suite.