Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands/start-swoole: allow customization of log-level #984

Closed
wants to merge 1 commit into from

Conversation

rochacon
Copy link

The current start command for Swoole mode does not allow customization of the log level via the options array.

This change add the same logic as we have for FrankenPHP and RoadRunner, giving precedence to the log-level option and falling back to the environment name as previous behavior.

@taylorotwell
Copy link
Member

Wouldn't it need to be added as an available option and passed to the command?

@taylorotwell taylorotwell marked this pull request as draft January 13, 2025 21:06
@rochacon rochacon force-pushed the allow-custom-swoole-log-level branch from 68fcad1 to 28a313a Compare January 16, 2025 10:18
@rochacon
Copy link
Author

rochacon commented Jan 16, 2025

I believe you're right @taylorotwell, I copied the check from src/Commands/StartFrankenPhpCommand.php and forgot to validate the flag. It should be correct now.

@rochacon rochacon marked this pull request as ready for review January 20, 2025 20:44
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@Cluster2a
Copy link

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Did you even take a look at the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants