-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/docker setup #68
Fix/docker setup #68
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @cardosofede on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/bJtcHNhhWwarQf83A . This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list. For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/opengpts/blob/main/CONTRIBUTING.md. |
51bf108
to
e5a6cac
Compare
This fix is really good and helped me getting it running with Docker. Is there any blocker from merging it? 🤔 |
Thanks @donatienthorez @albertoecf for the feedback! |
The main blocker for merging this is the removal of the root docker file, that can be used for deployments so it shouldn't be remove imo |
Hello @nfcampos, thank you for your feedback. I've adjusted the Docker setup for better modularity. The main Dockerfile, previously used for the backend, has been moved to the backend directory. A new Dockerfile is introduced for the frontend. This separation allows independent development and deployment of each component. For deployment, you can use The steps to get started are:
I've dropped you a message on Slack to discuss this approach in more detail. I'm open to feedback and willing to make any adjustments necessary to facilitate the merging of this PR. Thanks, Fede. |
@@ -4,7 +4,7 @@ | |||
"version": "0.0.0", | |||
"type": "module", | |||
"scripts": { | |||
"dev": "vite", | |||
"dev": "vite --host", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --host option allows the server to be accessed over the network, not just localhost. it's necessary when running via docker.
When running without --host and exposing the port from the container to the local machine we weren't able to see the output. With that argument, the Frontend was exposed.
hey, any updates here? |
I installed OpenGPTs from both source and this Docker setup. Docker is much simpler since |
This PR fixes the errors when trying to run the project from Docker.
Main changes: