Fix bug in streaming associated with additive chunks #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix for #154 |
jakerachleff
approved these changes
Nov 2, 2023
| else: | ||
| try: | ||
| final_output = final_output + chunk | ||
| except TypeError: |
There was a problem hiding this comment.
why do we need this? Can we add a comment?
There was a problem hiding this comment.
added comments, let me know if unclear i can add another PR afterwards with clarifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue in stream/astream endpoint associated with addable types
Have not been able to figure how to run sync unit tests yet with pytest:
streaming endpoint