Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add ruff rules TRY (tryceratops) #29388

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Jan 23, 2025

TRY004 ("use TypeError rather than ValueError") existing errors are marked as ignore to preserve backward compatibility.
LMK if you prefer to fix some of them.

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 4:56am

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jan 23, 2025
@cbornet cbornet force-pushed the ruff-core-try branch 3 times, most recently from 36da702 to 8c222bc Compare January 23, 2025 17:44
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jan 23, 2025
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 24, 2025
@efriis efriis enabled auto-merge (squash) January 24, 2025 04:56
@efriis efriis merged commit dbb6b7b into langchain-ai:master Jan 24, 2025
71 checks passed
@cbornet cbornet deleted the ruff-core-try branch January 24, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants