Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: Add Alibaba-Cloud's Lindorm as a integration #29085

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlwaysBluer
Copy link

@AlwaysBluer AlwaysBluer commented Jan 8, 2025

add lindorm introduction jupyternotebook.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 8, 2025
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 4:09am

@dosubot dosubot bot added Ɑ: embeddings Related to text embedding models module Ɑ: vector store Related to vector store module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jan 8, 2025
@AlwaysBluer
Copy link
Author

@jarib could you please review this pr. I only add the jupyternotebook for lindorm

Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Is there a Github repo associated with the package? If so:

  • Could you please add langchain-lindorm-integration to the package registry here?
  • You might want to update the package's homepage in PyPi to point there.

"\n",
"| Provider | Package |\n",
"|:--------:|:---------------------------------:|\n",
"| [Lindorm](/docs/integrations/providers/lindorm/) | [langchain-lindorm-integration](https://pypi.org/manage/projects/) |\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"| [Lindorm](/docs/integrations/providers/lindorm/) | [langchain-lindorm-integration](https://pypi.org/manage/projects/) |\n",
"| [Lindorm](/docs/integrations/providers/lindorm/) | [langchain-lindorm-integration](https://pypi.org/project/langchain-lindorm-integration/) |\n",

"languageId": "raw"
}
},
"source": "%pip install -qU \"langchain-lindorm-integration\""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should render this in a code block (see preview here)

Comment on lines +85 to +89
"```{=mdx}\n",
"import EmbeddingTabs from \"@theme/EmbeddingTabs\";\n",
"\n",
"<EmbeddingTabs/>\n",
"```\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not rendering properly (see preview here).

See here for an example of how to format this in a jupyter notebook.

@ccurme ccurme self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder Ɑ: embeddings Related to text embedding models module size:XL This PR changes 500-999 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants