openai[patch]: support optional fields in dict structured output with method="json_schema" #29075
+119
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
json_schema
method will currently error on the following:Optional fields in TypedDict:
Optional fields in JSON schema generated from a Pydantic object:
Fields with any non-null default (Pydantic, TypedDict, or JSON schema):
Here, we update
_convert_to_openai_response_format
to update optional fields to be required with possible'null'
type. This is a solution recommended in OpenAI's docs.Note that we make no changes to schemas specified as Pydantic models.
TODO: