Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring PDF loaders: 01 prepare #29062

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

pprados
Copy link
Contributor

@pprados pprados commented Jan 7, 2025

  • Refactoring PDF loaders step 1: "community: Refactoring PDF loaders to standardize approaches"

  • Description: Declare CloudBlobLoader in init.py. file_path is Union[str, PurePath] anywhere

  • Twitter handle: pprados

This is one part of a larger Pull Request (PR) that is too large to be submitted all at once.
This specific part focuses to prepare the update of all parsers.

For more details, see PR 28970.

@eyurtsev it's the start of a PR series.

Add file_path with PurePath
Add CloudBlobLoader in __init__
Replace Dict/List to dict/list
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 8:35am

@pprados pprados marked this pull request as ready for review January 7, 2025 08:42
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) labels Jan 7, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 7, 2025
@eyurtsev eyurtsev merged commit 2921597 into langchain-ai:master Jan 7, 2025
19 checks passed
@pprados pprados mentioned this pull request Jan 8, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants