Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: assert the indexed/unindexed rows for optimizing tests #3436

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

BubbleCal
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the chore label Feb 8, 2025
@BubbleCal BubbleCal marked this pull request as ready for review February 10, 2025 05:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (2295324) to head (f16b46e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3436      +/-   ##
==========================================
+ Coverage   78.88%   78.95%   +0.07%     
==========================================
  Files         251      251              
  Lines       92230    92267      +37     
  Branches    92230    92267      +37     
==========================================
+ Hits        72752    72851      +99     
+ Misses      16508    16444      -64     
- Partials     2970     2972       +2     
Flag Coverage Δ
unittests 78.95% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 changed the title chore: assert the indexed/unindexed rows for optimizing tests test: assert the indexed/unindexed rows for optimizing tests Feb 10, 2025
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@BubbleCal BubbleCal merged commit 8a61b69 into lancedb:main Feb 11, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants