Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support build lance java with rust release mode #3051

Merged
merged 2 commits into from
Oct 30, 2024
Merged

feat: support build lance java with rust release mode #3051

merged 2 commits into from
Oct 30, 2024

Conversation

SaintBacchus
Copy link
Collaborator

Now the lance java package only support build with debug mode.
Add a propertiy to support build with release mode.

## release mode
mvn clean package -DskipTests -Drust.release.build=true

## debug mode(default)
mvn clean package -DskipTests

@github-actions github-actions bot added enhancement New feature or request java labels Oct 28, 2024
@broccoliSpicy broccoliSpicy requested a review from LuQQiu October 29, 2024 02:52
@LuQQiu
Copy link
Contributor

LuQQiu commented Oct 30, 2024

.github/workflows/java-publish.yml could you help take a look if this java publish pipeline would be broken?

@SaintBacchus SaintBacchus force-pushed the SupportBuildJavaInReleaseMode branch from 3f155bd to 8744933 Compare October 30, 2024 09:12
@SaintBacchus
Copy link
Collaborator Author

SaintBacchus commented Oct 30, 2024 •
edited
Loading

.github/workflows/java-publish.yml could you help take a look if this java publish pipeline would be broken?

The default behavior of build rust was still debug mode. It would not break the pipeline.

But I review the configuration of java-publish.yml, the building on x86 platform was in debug mode.
I add this configuration for it.

@LuQQiu LuQQiu merged commit 2377632 into lancedb:main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuQQiu LuQQiu LuQQiu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaintBacchus @LuQQiu