Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document the merge insert operation in python #1892

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

westonpace
Copy link
Contributor

No description provided.

@westonpace westonpace marked this pull request as ready for review January 31, 2024 13:18
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos.

Also, do you want to add some examples to the Writing Dataset section? Having one code example for insert-if-not-exists and upsert each would be nice.

python/python/lance/dataset.py Outdated Show resolved Hide resolved
python/python/lance/dataset.py Outdated Show resolved Hide resolved
python/python/lance/dataset.py Outdated Show resolved Hide resolved
@westonpace
Copy link
Contributor Author

Also, do you want to add some examples to the Writing Dataset section?

I've added some examples

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@westonpace westonpace merged commit eccb929 into lancedb:main Jan 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants