Merge pull request #113 from gsteel/php-8.4-compatibility

Minor PHP 8.4 compatibility improvement, Deprecate `ArrayUtils::inArray()`

composer.json

@@ -31,10 +31,10 @@
     },
     "require-dev": {
         "laminas/laminas-coding-standard": "^2.5",
-        "phpbench/phpbench": "^1.2.14",
-        "phpunit/phpunit": "^10.3.3",
+        "phpbench/phpbench": "^1.2.15",
+        "phpunit/phpunit": "^10.5.8",
         "psalm/plugin-phpunit": "^0.18.4",
-        "vimeo/psalm": "^5.15.0"
+        "vimeo/psalm": "^5.20.0"
     },
     "autoload": {
         "psr-4": {

phpunit.xml.dist

@@ -11,6 +11,9 @@
     displayDetailsOnTestsThatTriggerWarnings="true"
     displayDetailsOnIncompleteTests="true"
     displayDetailsOnSkippedTests="true"
+    failOnDeprecation="true"
+    failOnNotice="true"
+    failOnWarning="true"
 >
     <testsuites>
         <testsuite name="laminas-stdlib Test Suite">

psalm-baseline.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.16.0@2897ba636551a8cb61601cc26f6ccfbba6c36591">
+<files psalm-version="5.20.0@3f284e96c9d9be6fe6b15c79416e1d1903dcfef4">
   <file src="src/AbstractOptions.php">
     <DocblockTypeContradiction>
       <code><![CDATA[! is_array($options) && ! $options instanceof Traversable]]></code>
@@ -216,11 +216,7 @@
       <code>$priority</code>
       <code>$priority</code>
     </InvalidArgument>
-    <MethodSignatureMismatch>
-      <code>public function insert($value, $priority)</code>
-    </MethodSignatureMismatch>
     <MethodSignatureMustProvideReturnType>
-      <code>insert</code>
       <code>serialize</code>
       <code>unserialize</code>
     </MethodSignatureMustProvideReturnType>

src/ArrayUtils.php

@@ -192,13 +192,15 @@ public static function isHashTable(mixed $value, $allowEmpty = false)
      * non-strict check is implemented. if $strict = -1, the default in_array
      * non-strict behaviour is used.
      *
+     * @deprecated This method will be removed in version 4.0 of this component
+     *
      * @param array $haystack
      * @param int|bool $strict
      * @return bool
      */
     public static function inArray(mixed $needle, array $haystack, $strict = false)
     {
-        if (! $strict) {
+        if ((bool) $strict === false) {
             if (is_int($needle) || is_float($needle)) {
                 $needle = (string) $needle;
             }

src/SplPriorityQueue.php

@@ -4,6 +4,7 @@
 
 namespace Laminas\Stdlib;
 
+use ReturnTypeWillChange;
 use Serializable;
 use UnexpectedValueException;
 
@@ -41,6 +42,7 @@ class SplPriorityQueue extends \SplPriorityQueue implements Serializable
      * @param  TPriority $priority
      * @return void
      */
+    #[ReturnTypeWillChange] // Inherited return type should be bool
     public function insert($value, $priority)
     {
         if (! is_array($priority)) {