Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Inflector Filter #220

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jan 7, 2025

  • Removes all getters and setters
  • Requires a plugin manager in the constructor
  • Makes the target option required
  • Removes the ability to use a reference for the target
  • Adds a factory for the filter

@froschdesign
Copy link
Member

The documentation needs also an update.

gsteel added 2 commits January 7, 2025 22:45
- Removes all getters and setters
- Requires a plugin manager in the constructor
- Makes the `target` option required
- Removes the ability to use a reference for the target
- Adds a factory for the filter

Signed-off-by: George Steel <[email protected]>
@gsteel gsteel force-pushed the v3/refactor-inflector-filter branch from 4df1539 to 52ddf94 Compare January 7, 2025 22:58
@gsteel
Copy link
Member Author

gsteel commented Jan 7, 2025

The documentation needs also an update.

@froschdesign Docs are done!

docs/book/v3/inflector.md Outdated Show resolved Hide resolved
Co-authored-by: Frank Brückner <[email protected]>
Signed-off-by: George Steel <[email protected]>
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍🏻

@gsteel gsteel self-assigned this Jan 7, 2025
@gsteel gsteel merged commit da7a4d5 into laminas:3.0.x Jan 7, 2025
16 of 17 checks passed
@gsteel gsteel deleted the v3/refactor-inflector-filter branch January 7, 2025 23:31
gsteel added a commit to gsteel/laminas-filter that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants