Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Laminas packages (major) #92

Open
wants to merge 2 commits into
base: 3.15.x
Choose a base branch
from
Open

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 4, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
laminas/laminas-coding-standard (source) ~2.5.0 -> ~3.0.0 age adoption passing confidence
laminas/laminas-servicemanager (source) ^3.22 -> ^4.0 age adoption passing confidence

Release Notes

laminas/laminas-coding-standard (laminas/laminas-coding-standard)

v3.0.1

Compare Source

Release Notes for 3.0.1

3.0.x bugfix release (patch)

3.0.1
  • Total issues resolved: 0
  • Total pull requests resolved: 2
  • Total contributors: 1
Documentation,Enhancement

v3.0.0

Compare Source

Release Notes for 3.0.0

Backwards incompatible release (major)

3.0.0
  • Total issues resolved: 0
  • Total pull requests resolved: 3
  • Total contributors: 2
renovate
Enhancement
BC Break,renovate
laminas/laminas-servicemanager (laminas/laminas-servicemanager)

v4.3.0

Compare Source

Release Notes for 4.3.0

Feature release (minor)

Introduces PHP 8.4 Support

4.3.0
  • Total issues resolved: 0
  • Total pull requests resolved: 5
  • Total contributors: 4
Enhancement
Documentation,Enhancement
renovate

v4.2.1

Compare Source

Release Notes for 4.2.1

4.2.x bugfix release (patch)

4.2.1
  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1
Documentation,Enhancement

v4.2.0

Compare Source

Release Notes for 4.2.0

Feature release (minor)

4.2.0
  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1
Enhancement

v4.1.0

Compare Source

Release Notes for 4.1.0

Feature release (minor)

4.1.0
  • Total issues resolved: 1
  • Total pull requests resolved: 3
  • Total contributors: 2
Documentation
Documentation,Enhancement

v4.0.2

Compare Source

Release Notes for 4.0.2

4.0.x bugfix release (patch)

4.0.2
  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1
Bug,Documentation

v4.0.1

Compare Source

Release Notes for 4.0.1

4.0.x bugfix release (patch)

4.0.1
  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1
Bug,Documentation

v4.0.0

Compare Source

Release Notes for 4.0.0
Release Notes for 4.0.0

laminas-servicemanager 4.0.0 is here and finally enables projects to consume psr/container v2.0.0 after 2 years along with several type-additions and plugin manager decoupling.

The migration guide is not written yet but will be at some point (once we added support for SM v4 to other components) later.

Added
  • Several native type-additions including property-, argument- and return-types and a lot more psalm types
  • ServiceManager#get, PluginManagerInterface#get and ServiceLocatorInterface#build now explicitly implement mixed as return-type to synchronize types with ContainerInterface#get
  • Support for psr/container v1.1 and v2.0
  • Ahead of Time factory creation for services explicitly using ReflectionBasedAbstractFactory via laminas-cli
Removed
  • Dropped support for PHP <8.1
  • Removed deprecated interfaces such as
    • Laminas\ServiceManager\AbstractFactoryInterface
    • Laminas\ServiceManager\FactoryInterface
    • Laminas\ServiceManager\InitializerInterface
    • Laminas\ServiceManager\DelegatorFactoryInterface
  • CLI commands which were exposed via vendor/bin are removed in favor of the laminas-cli integration. All CLI commands of v3.x are accessible via vendor/bin/laminas servicemanager:<v3.x command name> once laminas/laminas-cli is required in the projects dependencies
  • Removed deprecated ConfigInterface and Config-class since these files did not provide any validation logic and were just used to proxy the configuration array structure
  • Removed AbstractPluginManager#validate and AbstractPluginManager::$instanceOf property as in v3.x, implementing plugin managers were able to implicitly validate mixed. In case an implementing plugin manager is providing a single $instanceOf such as laminas-cache, there is a new class AbstractSingleInstancePluginManager available which requires the $instanceOf property to be configured
Breaking Changes
  • AbstractPluginManager does not extend ServiceManager anymore and instead uses an own ServiceManager instance under the hood to manage plugin manager related services which can be configured the same way as in v3.x
  • Dedicated CLI commands which were previously linked to vendor/bin are now integrated via laminas-cli and can be called via vendor/bin/laminas once laminas/laminas-cli is part of the projects requirements. Read more about how to consume these commands here.
  • AbstractPluginManager does not provide the validate-Method anymore and requires migration action such as:
    • extend AbstractSingleInstancePluginManager in case the plugin manager only provides instances of a specific interface- or class-string (please be aware that the $instanceOf property now requires native string property type)
    • implement validate method and verify whatever type has to be returned and/or just allow mixed as v3.x did when omitting $instanceOf property
  • Removed deprecated ConfigInterface and Config-class since these files did not provide any validation logic and were just used to proxy the configuration array structure
  • neither ServiceManager nor AbstractPluginManager do validate the provided configuration at runtime anymore. due to the psalm-types provided to ServiceManager#__construct, ServiceManager#configure, AbstractPluginManager#__construct and AbstractPluginManager#configure, the configuration schema is strictly typed and thus, a miss-configuration can be mitigated on static-analysis level prior actual runtime
  • AbstractPluginManager#get does not accept options anymore, in case an instance with options needs to be created, AbstractPluginManager#build has to be used
4.0.0
  • Total issues resolved: 7
  • Total pull requests resolved: 14
  • Total contributors: 6
Enhancement
BC Break,Enhancement
RFC
BC Break
renovate
Bug

v3.23.0

Compare Source

Release Notes for 3.23.0
3.23.0
  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1
Enhancement

v3.22.1

Compare Source

Release Notes for 3.22.1

3.22.x bugfix release (patch)

3.22.1
  • Total issues resolved: 1
  • Total pull requests resolved: 1
  • Total contributors: 1
Enhancement

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

Read more information about the use of Renovate Bot within Laminas.

@renovate renovate bot added the renovate label Mar 4, 2024
@renovate renovate bot force-pushed the renovate/major-laminas branch from 9549ec7 to 9b3e53f Compare May 2, 2024 12:57
@renovate renovate bot changed the base branch from 3.14.x to 3.15.x May 2, 2024 13:01
| datasource | package                         | from   | to    |
| ---------- | ------------------------------- | ------ | ----- |
| packagist  | laminas/laminas-coding-standard | 2.5.0  | 3.0.0 |
| packagist  | laminas/laminas-servicemanager  | 3.22.0 | 4.2.0 |


Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/major-laminas branch from 9b3e53f to 2a3f5ff Compare October 12, 2024 01:38
@renovate renovate bot changed the title Update dependency laminas/laminas-servicemanager to v4 Update Laminas packages (major) Oct 12, 2024
Copy link
Contributor Author

renovate bot commented Oct 12, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: composer.lock
Command failed: composer update laminas/laminas-coding-standard:3.0.0 laminas/laminas-servicemanager:4.2.0 --with-dependencies --ignore-platform-req='ext-*' --ignore-platform-req='lib-*' --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins
Loading composer repositories with package information
Dependency squizlabs/php_codesniffer is also a root requirement. Package has not been listed as an update argument, so keeping locked at old version. Use --with-all-dependencies (-W) to include root dependencies.
Dependency laminas/laminas-stdlib is also a root requirement. Package has not been listed as an update argument, so keeping locked at old version. Use --with-all-dependencies (-W) to include root dependencies.
Dependency psr/container is also a root requirement. Package has not been listed as an update argument, so keeping locked at old version. Use --with-all-dependencies (-W) to include root dependencies.
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires laminas/laminas-coding-standard ~3.0.0 -> satisfiable by laminas/laminas-coding-standard[3.0.0].
    - laminas/laminas-coding-standard 3.0.0 requires squizlabs/php_codesniffer ^3.10 -> found squizlabs/php_codesniffer[3.10.0, 3.10.1, 3.10.2, 3.10.3] but the package is fixed to 3.7.2 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Copy link
Contributor Author

renovate bot commented Nov 20, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@tux-rampage tux-rampage self-assigned this Nov 20, 2024
@tux-rampage tux-rampage added the Dependencies Updates and changes to dependencies label Nov 20, 2024
@tux-rampage tux-rampage added this to the 3.15.0 milestone Nov 20, 2024
@tux-rampage tux-rampage requested a review from Ocramius November 20, 2024 11:58
*/
public function canCreate(ContainerInterface $container, $requestedName)
public function canCreate(ContainerInterface $container, $requestedName): bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is not final, so adding these types is a BC break 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, in this case, laminas-service-manager 4.0 cannot be supported without a major release.

In fact we have to add a conflict to laminas-service-manager >= 4.0 for the 3.x branches, since this class is not interface compatible with that version.

Another question: Is this even done correctly by editing this branch or should the renovate Issues rather be addressed with a separate PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can open a new major version here: just needs to be against 4.0.x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already changed the milestone here. I have some suggestions for 4.0.x in #95 to be addressed with the TSC.
This component needs some cleanup 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Dependencies Updates and changes to dependencies renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants