Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set default proptest limits #1521

Merged
merged 2 commits into from
Jan 2, 2024
Merged

ci: set default proptest limits #1521

merged 2 commits into from
Jan 2, 2024

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Dec 20, 2023

Set default values for proptest cases for the following scenarios:

  • Regular, local development: 10 cases
  • PR CI pipeline: use the old default, 100 cases
  • Daily "fresh run" pipeline: be more aggressive, try 10000 different cases

@Oppen Oppen force-pushed the ci/proptest_optimizations branch from d2b2607 to e71a2eb Compare December 20, 2023 17:23
@Oppen Oppen added the pipelines This PR/issue is exclusively about improving our CI label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2636fd2) 97.21% compared to head (cd84562) 97.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          90       90           
  Lines       36464    36464           
=======================================
  Hits        35449    35449           
  Misses       1015     1015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 20, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.262 ± 0.026 2.234 2.314 1.01 ± 0.01
head big_factorial 2.250 ± 0.012 2.235 2.272 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.236 ± 0.016 2.213 2.258 1.00 ± 0.01
head big_fibonacci 2.228 ± 0.015 2.212 2.256 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.195 ± 0.065 8.121 8.320 1.00
head blake2s_integration_benchmark 8.253 ± 0.082 8.122 8.349 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.305 ± 0.052 2.266 2.428 1.01 ± 0.02
head compare_arrays_200000 2.283 ± 0.012 2.270 2.309 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.441 ± 0.007 1.433 1.450 1.00
head dict_integration_benchmark 1.462 ± 0.010 1.448 1.478 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.290 ± 0.009 1.282 1.307 1.00
head field_arithmetic_get_square_benchmark 1.294 ± 0.013 1.282 1.316 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.285 ± 0.200 8.168 8.833 1.00 ± 0.03
head integration_builtins 8.254 ± 0.074 8.170 8.354 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.490 ± 0.074 8.425 8.626 1.00
head keccak_integration_benchmark 8.520 ± 0.096 8.418 8.644 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.318 ± 0.019 2.301 2.357 1.00 ± 0.01
head linear_search 2.317 ± 0.014 2.305 2.352 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.566 ± 0.013 1.557 1.601 1.00
head math_cmp_and_pow_integration_benchmark 1.573 ± 0.010 1.561 1.597 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.429 ± 0.006 1.422 1.439 1.00
head math_integration_benchmark 1.433 ± 0.008 1.420 1.445 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.252 ± 0.008 1.246 1.265 1.00
head memory_integration_benchmark 1.254 ± 0.008 1.248 1.266 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.609 ± 0.014 1.595 1.643 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.600 ± 0.009 1.593 1.617 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 604.7 ± 1.4 602.9 606.3 1.00 ± 0.00
head pedersen 603.1 ± 1.3 601.3 605.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.053 ± 0.007 1.043 1.066 1.00
head poseidon_integration_benchmark 1.057 ± 0.012 1.046 1.087 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.946 ± 0.007 1.935 1.957 1.00
head secp_integration_benchmark 1.954 ± 0.010 1.941 1.973 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 749.7 ± 1.6 747.6 752.8 1.00
head set_integration_benchmark 751.3 ± 1.9 748.1 754.0 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.545 ± 0.025 4.517 4.597 1.00 ± 0.01
head uint256_integration_benchmark 4.537 ± 0.039 4.503 4.639 1.00

@fmoletta fmoletta added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2024
@fmoletta fmoletta added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 88a5bf1 Jan 2, 2024
50 checks passed
@fmoletta fmoletta deleted the ci/proptest_optimizations branch January 2, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants