-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various warnings and upgrade catch2 to 3.8.0 version #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\optional(82,17): warning C4244: 'initializing': conversion from '_Ty' to 'unsigned int', possible loss of data [D:\a\visp\visp\build\modules\core\visp_core.vcxproj] C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\optional(82,17): warning C4244: with [D:\a\visp\visp\build\modules\core\visp_core.vcxproj] C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\optional(82,17): warning C4244: [ [D:\a\visp\visp\build\modules\core\visp_core.vcxproj] C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\optional(82,17): warning C4244: _Ty=__int64 [D:\a\visp\visp\build\modules\core\visp_core.vcxproj] C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\optional(82,17): warning C4244: ] [D:\a\visp\visp\build\modules\core\visp_core.vcxproj] (compiling source file '../../../modules/core/src/munkres/vpMunkres.cpp') C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\optional(82,17): the template instantiation context (the oldest one first) is D:\a\visp\visp\modules\core\src\munkres\vpMunkres.cpp(51,41): see reference to function template instantiation 'std::optional<unsigned int> std::make_optional<unsigned int,__int64,0>(__int64 &&) noexcept' being compiled C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\optional(955,27): see reference to function template instantiation 'std::optional<unsigned int>::optional<_Ty,0>(std::in_place_t,_Ty &&) noexcept' being compiled with [ _Ty=__int64 ] C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\optional(231,18): see reference to function template instantiation 'std::_Optional_construct_base<_Ty>::_Optional_construct_base<__int64>(std::in_place_t,__int64 &&)' being compiled with [ _Ty=unsigned int ] D:\a\visp\visp\modules\core\src\munkres\vpMunkres.cpp(191,1): see reference to function template instantiation 'std::_Optional_destruct_base<_Ty,true>::_Optional_destruct_base<__int64>(std::in_place_t,__int64 &&) noexcept' being compiled with [ _Ty=unsigned int ]
fspindle
changed the title
Fix various warnings
Fix various warnings and upgrade catch2 to 3.8.0 version
Jan 18, 2025
- target ubuntu-22.04 and ubuntu-latest (24.04) - use lastest gcc and g++ compiler
…/usr/bin/gcc, /usr/bin/g++, 98) In file included from /tmp/usr/local/include/visp3/core/vpColor.h:38, from /tmp/usr/local/include/visp3/blob/vpDot2.h:42, from /home/runner/visp_sample/blob/sample-vpDot2-2.cpp:1: /tmp/usr/local/include/visp3/core/vpRGBa.h:187:20: error: static assertion failed 187 | static_assert(std::is_trivially_assignable_v<vpRGBa, vpRGBa>);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.