Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Update CLI to use the new plenum defaults #864

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix(cli): Update CLI to use the new plenum defaults #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dragonfly_energy/cli/simulate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ def simulate():
'multipliers on each Building story will be passed along to the '
'generated Honeybee Room objects or if full geometry objects should be '
'written for each story in the building.', default=True, show_default=True)
@click.option('--no-plenum/--plenum', ' /-p', help='Flag to indicate whether '
'ceiling/floor plenums should be auto-generated for the Rooms.',
default=True, show_default=True)
@click.option('--plenum/--no-plenum', '-p/-np', help='Flag to indicate whether '
'ceiling/floor plenum depths assigned to Room2Ds should generate '
'distinct 3D Rooms in the translation.', default=True, show_default=True)
@click.option('--no-cap/--cap', ' /-c', help='Flag to indicate whether context shade '
'buildings should be capped with a top face.',
default=True, show_default=True)
Expand Down Expand Up @@ -75,7 +75,7 @@ def simulate():
'osm, idf, sql. By default the list will be printed out to stdout',
type=click.File('w'), default='-', show_default=True)
def simulate_model(model_json, epw_file, sim_par_json, obj_per_model, multiplier,
no_plenum, no_cap, shade_dist, no_ceil_adjacency,
plenum, no_cap, shade_dist, no_ceil_adjacency,
measures, folder, log_file):
"""Simulate a Dragonfly Model JSON file in EnergyPlus.

Expand Down Expand Up @@ -156,11 +156,11 @@ def write_sim_par(sim_par):
model.separate_top_bottom_floors()

# convert Dragonfly Model to Honeybee
add_plenum = not no_plenum
no_plenum = not plenum
cap = not no_cap
ceil_adjacency = not no_ceil_adjacency
hb_models = model.to_honeybee(
obj_per_model, shade_dist, multiplier, add_plenum, cap, ceil_adjacency)
obj_per_model, shade_dist, multiplier, no_plenum, cap, ceil_adjacency)

# write out the honeybee JSONs
osms = []
Expand Down
Loading