Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store accelerator metadata on redis #1157

Merged
merged 6 commits into from
Mar 15, 2023
Merged

feat: store accelerator metadata on redis #1157

merged 6 commits into from
Mar 15, 2023

Conversation

kyujin-cho
Copy link
Member

This resolves #1156. Ref #1153

@kyujin-cho kyujin-cho added comp:manager Related to Manager component comp:agent Related to Agent component skip:changelog Make the action workflow to skip towncrier check labels Mar 10, 2023
@kyujin-cho kyujin-cho self-assigned this Mar 10, 2023
@kyujin-cho kyujin-cho requested a review from achimnol March 10, 2023 17:18
@kyujin-cho kyujin-cho added this to the 23.03 milestone Mar 10, 2023
@github-actions github-actions bot added urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! type:enhance Enhance component, behavior, internals without user-facing features labels Mar 10, 2023
@achimnol
Copy link
Member

The number format fields should be updated following #1158.

@achimnol achimnol marked this pull request as draft March 14, 2023 08:24
@kyujin-cho kyujin-cho marked this pull request as ready for review March 14, 2023 08:50
@kyujin-cho kyujin-cho added this pull request to the merge queue Mar 15, 2023
Merged via the queue into main with commit fbec825 Mar 15, 2023
@kyujin-cho kyujin-cho deleted the feature/accelerator-metadata-on-redis branch March 15, 2023 01:49
@Yaminyam Yaminyam added the size:M 30~100 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol approved these changes

Assignees

@kyujin-cho kyujin-cho

Labels
comp:agent Related to Agent component comp:manager Related to Manager component size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check type:enhance Enhance component, behavior, internals without user-facing features urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Projects
None yet
Milestone
23.03
Development

Successfully merging this pull request may close these issues.

Improve #1153 by making the resource slot metadata query to be O(1)
3 participants
@kyujin-cho @achimnol @Yaminyam