-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added backports to procedure #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @Alopalao, great to have this doc consolidated. Left some minor suggestions, and there's one main point regarding e2e we need to handle as a pre-requisite, check it out below.
procedures/prs.md
Outdated
|
||
### Final observations. | ||
|
||
PR created for a previous version does not run automatic tests so make sure to run unit tests and end-to-end tests to assure that the changes are safe to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's also make unit tests mandatory for backports but only running locally on tox, for e2e tests check out the discussion here #48 (comment), e2e tests definitely needs to be run, but before we ask for it too, our https://github.com/kytos-ng/kytos-end-to-end-tests test suites need to also have compatibility versions too such as 2023.2, 2024.1 and so on, and needs to be bumped with the final release too, just so older tests still pass, since newer ones might or might not be fully compatible. So, we need to also map that effort and make sure that part is ready for 2023.2 and 2024.1 if we'll ask for it, can you take a lead on this and map an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue created, kytos-ng/kytos-end-to-end-tests#340
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution, Aldo! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @Alopalao, and great to also have the initiative with kytos-ng/kytos-end-to-end-tests#340, let's see how it'll unfold.
Closes #48
Summary
Added Backport to procedure with some examples.
Local Tests
N/A
End-to-End Tests
N/A