Added Progressbar Support #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added default QB progressbar and an_progBar as options for a progressbar.
Added progressbar options in config.lua file.
|
This has been configured for Picking Up, taking otu, and dropping off the package between the van and npc. |
kylemcshea
reviewed
Jan 5, 2024
| @@ -159,6 +173,31 @@ function pickupMail() | |||
| return | |||
| end | |||
|
|
|||
| if (USE_PROGRESS_BAR) then | |||
| if (PROGRESS_BAR == 'qb') then | |||
| QBCore.Functions.Progressbar("grab_mail", "Grabbing Package from Mailbox", Config.PROGRESS_BAR_DURATION, false, false, { | |||
Comment on lines
+1
to
+10
| if (Config.FRAMEWORK == 'qb') then | ||
| FRAMEWORK = Config.GET_CORE | ||
| elseif (Config.FRAMEWORK == 'esx') then | ||
| FRAMEWORK = exports["es_extended"]:getSharedObject() | ||
| elseif (Config.FRAMEWORK == 'esx-old') then | ||
| TriggerEvent('esx:getSharedObject', function(obj) FRAMEWORK = obj end) | ||
| else | ||
| -- put in custom logic to grab framework and delete print code underneath | ||
| print('^6[^3dream-postal^6]^0 Unsupported Framework detected!') | ||
| end |
There was a problem hiding this comment.
We already grab framework in client_util so this code is not needed. With that being said is client_util loaded in first? If not then we must change order in fxmanifest.lua
Comment on lines
+732
to
+733
|
|
||
|
|
There was a problem hiding this comment.
We can remove this added lines
| @@ -44,6 +44,11 @@ Config.PAY_MULTIPLIER = 1.5 | |||
| -- Whether or not to show the white arrow marker above the drop off ped & blue postal boxes. | |||
| Config.SHOW_WHITE_ARROW_MARKER = true | |||
|
|
|||
| -- Whether or not to show progressbar and what kind/duration. | |||
| Config.USE_PROGRESS_BAR = true -- use progress bar or not | |||
There was a problem hiding this comment.
I'm thinking we initialize this to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added progressbar support for the default qb-progressbar as well as an_progBar noted in the issue.