Skip to content

Commit

Permalink
address @fedarko's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kwcantrell committed Aug 26, 2021
1 parent 9f54080 commit 4a769a7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
5 changes: 1 addition & 4 deletions empress/support_files/js/empress.js
Original file line number Diff line number Diff line change
Expand Up @@ -3820,10 +3820,7 @@ define([
* @return true if node has feature metadata else false.
*/
Empress.prototype.hasFeatureMetadata = function (node) {
if (_.has(this._tipMetadata, node) || _.has(this._intMetadata, node)) {
return true;
}
return false;
return _.has(this._tipMetadata, node) || _.has(this._intMetadata, node);
};

return Empress;
Expand Down
4 changes: 1 addition & 3 deletions tests/test-barplots.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,14 @@ require([
"BarplotLayer",
"UtilitiesForTesting",
"Colorer",
"util",
], function (
$,
_,
spectrum,
Empress,
BarplotLayer,
UtilitiesForTesting,
Colorer,
util
Colorer
) {
module("Barplots", {
setup: function () {
Expand Down

0 comments on commit 4a769a7

Please sign in to comment.