Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple translation files #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rp84e
Copy link
Contributor

@rp84e rp84e commented Jan 27, 2025

multiple translation files #34

  • Pull Request title is consistent with the implemented feature, fix etc.
  • I have followed proper descriptive code style and conventions
  • The code is self-documenting and has no unnecessary comments. I named the functions and variables to clearly describe their purpose.
  • I have added Unit Tests and coverage is 70%+
  • I have tested and verified this implementation and it works as expected

multiple translation files kwado-tech#34
@rp84e
Copy link
Contributor Author

rp84e commented Jan 27, 2025

@kwado-tech Please review and merge this new PR before creating a new version! Thx in advance!

@kwado-tech
Copy link
Owner

kwado-tech commented Feb 1, 2025

Hey @rp84e this pr makes unrelated files changes. This changes should be made on a new cut from main branch instead.

Lets modify the documentation as well to indicate this additional support in a separate PR instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants