Remove QWebEngine usage in core. Rewrite web package manager #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of a webpage; drop QWebEngine usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 big modifications.
The first one is related to the help module, that right now can use as its backend Qt's QTextBrowser (a simple html browser) or QWebEngine (based on Chromium, supports javascript etc, usually quite outdated and with a bad security record).
This PR removes the QWEbEngine backend from the help module, since we don't need it features, it's more bloated, and it never appeared in any windows release anyway.
The second one is related to WebPackageManager, aka the "get more themes" and "get more addons" features.
Right now they use QWebEngine to show a page from www.kvirc.net and download files via ftp.
This feature is broken since ages because ftp downloads aren't supported anymore and sometimes because the www.kvirc.net website has a broken ssl cert.
This PR rewrites the WebPackageManager to use plain http requests to a json file containing the information about themes/addons. Right now the file is loaded from http://127.0.0.1/ for local testing, but the target is to host the files in a github repo (implementing #1733) so that contributors can use issues and pull requests.
Once these changes are in, the only usage of QWebEngine left is in the "object" module.
Prerequisite to fix #1733
Note: this PR needs an additional commit to fix the theme/addon urls once the repositories are created.