Settings: include styleName in font; fix #2567 #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This does help... as long as user doesn't change the system locale. Because the localized string "Курсив"/"Italic" is saved in settings. When I flip between different LC_ALL, I see the same behavior as without this fix. I guess that's still better than what we have now :( |
|
Correct, as long as the font uses localized style names there's no way we can support switching locales. |
This was referenced Dec 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KviStringConversion: is used to convert a font from/to a string for settings storage.
This PR adds "styleName" to the font properties saved in the settings file.
This property is needed by QFontDialog to show the correct font style (eg. italic, bold, etc) for certain fonts.
One example of this font is MS' Verdana, that includes localized version for the style names.