Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow reference sub-factories in SelfAttribute #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ADR-007
Copy link

@ADR-007 ADR-007 commented Feb 6, 2024

BREAKING CHANGE:
AsyncSQLAlchemyFactory.build() and AsyncSQLAlchemyFactory.build_batch() now have to be awaited

BREAKING CHANGE:
AsyncSQLAlchemyFactory.build() now has has to be awaited
@ADR-007
Copy link
Author

ADR-007 commented Feb 28, 2024

The error doesn't look related to my changes:

      def finalizer() -> None:
          """
          Cleans up the DB after testing. Must be called as part of the test environment teardown.
          """
          _restore_default()
          loop = _LOOP
          loop._selector = _SELECTOR  # type: ignore
  >       loop.run_until_complete(Tortoise._drop_databases())

@FadingFog
Copy link

@ADR-007 Thanks for PR. Same issue with build_batch() method. Can you please fix this too?

@ADR-007
Copy link
Author

ADR-007 commented Jun 6, 2024

@ADR-007 Thanks for PR. Same issue with the build_batch() method. Can you please fix this too?

Sure, but I'm quite busy now :(

@ADR-007
Copy link
Author

ADR-007 commented Jun 12, 2024

@ADR-007 Thanks for PR. Same issue with build_batch() method. Can you please fix this too?

It should be good now :)

@FadingFog
Copy link

@kuzxnia Hi, can you review & merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants