-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow reference sub-factories in SelfAttribute #8
base: master
Are you sure you want to change the base?
fix: allow reference sub-factories in SelfAttribute #8
Conversation
BREAKING CHANGE: AsyncSQLAlchemyFactory.build() now has has to be awaited
The error doesn't look related to my changes: def finalizer() -> None:
"""
Cleans up the DB after testing. Must be called as part of the test environment teardown.
"""
_restore_default()
loop = _LOOP
loop._selector = _SELECTOR # type: ignore
> loop.run_until_complete(Tortoise._drop_databases()) |
@ADR-007 Thanks for PR. Same issue with build_batch() method. Can you please fix this too? |
Sure, but I'm quite busy now :( |
It should be good now :) |
@kuzxnia Hi, can you review & merge this PR? |
BREAKING CHANGE:
AsyncSQLAlchemyFactory.build()
andAsyncSQLAlchemyFactory.build_batch()
now have to be awaited