Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strats.json #29

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Chance103
Copy link

Panefmm and c4.5 need to be updated as of 1.19.4 they are now 5t and not 4t

Panefmm and c4.5 need to be updated as of 1.19.4 they are now 5t and not 4t
@ghost
Copy link

ghost commented Sep 6, 2023

You updated it globally and so it will also be updated on 1.8.

@Chance103 Chance103 closed this Sep 7, 2023
@Chance103
Copy link
Author

Good point, I will try and figure out how to fix this

@Chance103 Chance103 reopened this Sep 7, 2023
@Chance103 Chance103 closed this Sep 7, 2023
@Chance103 Chance103 reopened this Sep 7, 2023
@Chance103
Copy link
Author

alright I have fixed the issue, sorry for all the opens and closes, this is my first PR

@kurrycat2004
Copy link
Owner

I will think of a way to add version specific timings when i update the timing code to add optional inputs and mirrored strats, to not have a strats.json for every mc version. i will leave this open for now

@notdevcody notdevcody marked this pull request as draft October 29, 2023 18:39
@MinecraftSeaTurtle
Copy link

I would like to note that true pane fmm in 1.19.4+ is not -5t run 1t but sprintless -4t add sprint 1t later run 1t. This may not be best to put as the "normal" strat, so I suggest that all pane fmm-like timings be treated similarly with both the tick timing and run timing included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants