Fix issue where #[cfg(...)] are not propogated to emitted debug implementation. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not an expert on proc macros, so if you have anything you'd like to see different, much appreciated! |
|
Bump? @kupiakos I was hoping to get this soon, as there's some other changes that I'd like to merge in the igvm crate that needs this. |
kupiakos
reviewed
Jun 17, 2024
| Red = 1, | ||
| Blue = 2, | ||
| /// Test doc | ||
| #[cfg(feature = "orange")] |
There was a problem hiding this comment.
D'you have any ideas for testing that this works correctly with the cfg enabled?
There was a problem hiding this comment.
Hmm... we could maybe have a test enabled feature and have an enumeration with cfg enabled on it? Perhaps I should have done that in the PR.
FWIW in the igvm repo we're testing both, but I can see about submitting a follow up PR to do the same here.
|
Sorry for the delay! Published in v0.5.2. |
|
Thanks, no problem appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using feature gates with debug derives, the generated debug implementation does not correctly cfg gate enums that should be cfg gated, resulting in code that does not compile with the given feature.
Fix this by making sure we emit
[#cfg(...)]to the generated debug variants so that the code is correctly feature gated.Fixes #19