chore: TableコンポーネントのuseReelCells のロジックを整理する #5248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AtsushiM
changed the title
AtsushiM
commented
Jan 9, 2025
| @@ -7,42 +7,40 @@ export const useReelCells = () => { | |||
| useEffect(() => { | |||
| const currentRef = tableWrapperRef.current | |||
|
|
|||
| if (!currentRef) { | |||
There was a problem hiding this comment.
currentRefが存在しない限り、後続の処理は不要だったため、ロジックを修正しています
もともとのロジックでは各箇所にcurrentRefの存在チェックがありましたが、分散してしまい見づらかったのでここに集約させます。効率もよいです。
AtsushiM
commented
Jan 9, 2025
| }) | ||
| const stickyCells = currentRef.querySelectorAll('.fixedElement') | ||
|
|
||
| if (!stickyCells) { |
There was a problem hiding this comment.
stickyCellsが存在しない場合、後続のロジックは不要だったのでifを追加しています
AtsushiM
commented
Jan 9, 2025
Comment on lines
+23
to
+26
| const shouldFix = maxScrollLeft > 0 && scrollLeft < maxScrollLeft | ||
| const settableShowShadow = shouldFix | ||
| ? scrollLeft > 0 | ||
| : maxScrollLeft !== 0 || scrollLeft !== 0 |
There was a problem hiding this comment.
forEachの中で毎回計算する必要がなかったため、forの外で計算を済ませておきます
AtsushiM
requested review from
yt-ymmt and
Qs-F
and removed request for
a team
AtsushiM
commented
Jan 10, 2025
| : maxScrollLeft !== 0 || scrollLeft !== 0 | ||
|
|
||
| stickyCells.forEach((cell) => { | ||
| cell.classList.toggle('fixed', shouldFix) |
There was a problem hiding this comment.
classListに対するadd, removeはそれぞれtoggleの第2引数にtrue, falseを渡すことで表現できます。
Qs-F
approved these changes
Jan 10, 2025
| @@ -7,42 +7,40 @@ export const useReelCells = () => { | |||
| useEffect(() => { | |||
| const currentRef = tableWrapperRef.current | |||
|
|
|||
| if (!currentRef) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
TableのuseReelCellsのロジックを整理し、効率化、可読性の向上を試みます
変更内容
確認方法