Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): do not mount TLS bundle if webhook does not use custom TLS certificate #62

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Jan 2, 2025

No description provided.

@SOF3 SOF3 requested a review from DeliangFan January 2, 2025 10:36
@SOF3 SOF3 enabled auto-merge January 2, 2025 10:36
@SOF3 SOF3 added the bug Something isn't working label Jan 2, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.47%. Comparing base (0f6265d) to head (ab74e25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   38.47%   38.47%           
=======================================
  Files          94       94           
  Lines        6638     6638           
=======================================
  Hits         2554     2554           
  Misses       3939     3939           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3 SOF3 added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Jan 7, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@SOF3 SOF3 added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Jan 7, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@SOF3 SOF3 added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Jan 7, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@SOF3 SOF3 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into kubewharf:main with commit 535fa3f Jan 7, 2025
5 checks passed
@SOF3 SOF3 deleted the custom-tls-no-bundle branch January 7, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants