-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kustomize openshift #91
base: main
Are you sure you want to change the base?
Conversation
cc @oshoval |
@@ -0,0 +1,43 @@ | |||
# Adds namespace to all resources. | |||
namespace: openshift-kubevirt-ipam-controller-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you can just do whatever ns you want
less kustomize = better imho (no kustomize at all = best)
if it helps, this worked for me i think
https://gist.github.com/oshoval/d5db815ebea60eb1777a838bee0530b9#file-gistfile1-txt-L14
might just need to add the scc fix for 4.19
config/openshift/kustomization.yaml
Outdated
# "wordpress" becomes "alices-wordpress". | ||
# Note that it should also match with the prefix (text before '-') of the namespace | ||
# field above. | ||
namePrefix: kubevirt-ipam-controller- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this must match w/ the namespace name we have above (line 2).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would say dont do kustomize at all, provide static manifest imho
much easier, and also mostly for making testing comfort
last time kustomize on OCP did headache
f54e55c
to
4a3fcd4
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if you insist using kustomize |
Signed-off-by: Miguel Duarte Barroso <[email protected]>
4a3fcd4
to
2b0a02e
Compare
What this PR does / why we need it:
This PR provides an installation manifest to deploy the component correctly in OpenShift.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: