Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize openshift #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Feb 4, 2025

What this PR does / why we need it:
This PR provides an installation manifest to deploy the component correctly in OpenShift.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Provide an OpenShift deployment manifest.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Feb 4, 2025
@maiqueb maiqueb changed the base branch from kustomize-openshift to main February 4, 2025 16:00
@maiqueb
Copy link
Collaborator Author

maiqueb commented Feb 4, 2025

cc @oshoval

@@ -0,0 +1,43 @@
# Adds namespace to all resources.
namespace: openshift-kubevirt-ipam-controller-system
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oshoval / @qinqon should this be openshift-cnv ??

I don't think so, since this method of installation is just for testing this works without having to grab the whole CNV bundle (i.e. smoke tests, assert this deploys, etc).

Copy link
Collaborator

@oshoval oshoval Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can just do whatever ns you want
less kustomize = better imho (no kustomize at all = best)

if it helps, this worked for me i think
https://gist.github.com/oshoval/d5db815ebea60eb1777a838bee0530b9#file-gistfile1-txt-L14

might just need to add the scc fix for 4.19

# "wordpress" becomes "alices-wordpress".
# Note that it should also match with the prefix (text before '-') of the namespace
# field above.
namePrefix: kubevirt-ipam-controller-
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this must match w/ the namespace name we have above (line 2).

Copy link
Collaborator

@oshoval oshoval Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would say dont do kustomize at all, provide static manifest imho
much easier, and also mostly for making testing comfort
last time kustomize on OCP did headache

@maiqueb maiqueb force-pushed the kustomize-openshift branch from f54e55c to 4a3fcd4 Compare February 4, 2025 16:07
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maiqueb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval
Copy link
Collaborator

oshoval commented Feb 4, 2025

if you insist using kustomize
maybe you can give AI the input manifest and output and it will generate you the kustomize

@maiqueb maiqueb force-pushed the kustomize-openshift branch from 4a3fcd4 to 2b0a02e Compare February 4, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants