MTV-1696: How MTV uses virt-v2v #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardHoch
force-pushed
the
virt_v2v_mtv
branch
2 times, most recently
from
c7b0ba3 to
19a0baf
Compare
anarnold97
reviewed
Jan 29, 2025
anarnold97
reviewed
Jan 29, 2025
anarnold97
reviewed
Jan 29, 2025
anarnold97
reviewed
Jan 29, 2025
|
|
||
| * Removals: | ||
|
|
||
| ** Unnecessary or former hypervisor-specific files (for example, VMware tools, VirtualBox additions) |
There was a problem hiding this comment.
Suggested change
| ** Unnecessary or former hypervisor-specific files (for example, VMware tools, VirtualBox additions) | |
| ** Unnecessary or former hypervisor-specific files, for example, VMware tools, VirtualBox additions. |
anarnold97
reviewed
Jan 29, 2025
anarnold97
reviewed
Jan 29, 2025
| [id="permissions-virt-v2v_{context}"] | ||
| == Permissions and virt-v2v | ||
|
|
||
| `virt-v2v` does not require permissions or access credentials of the guest operating system itself because `virt-v2v` is not run against a running VM, but only against the disks of a VM. |
There was a problem hiding this comment.
Suggested change
| `virt-v2v` does not require permissions or access credentials of the guest operating system itself because `virt-v2v` is not run against a running VM, but only against the disks of a VM. | |
| `virt-v2v` does not require permissions or access credentials for the guest operating system itself because `virt-v2v` is not run against a running VM, but only against the disks of a VM. |
anarnold97
requested changes
Jan 29, 2025
RichardHoch
force-pushed
the
virt_v2v_mtv
branch
from
19a0baf to
186e531
Compare
Signed-off-by: RichardHoch <[email protected]>
RichardHoch
force-pushed
the
virt_v2v_mtv
branch
from
c38c712 to
9b53394
Compare
|
@anarnold97 I made trhe changes you suggested. Please review this PR again. Thanks. |
anarnold97
reviewed
Jan 30, 2025
anarnold97
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTV 2.8
Partly resolves https://issues.redhat.com/browse/MTV-1696 by adding a section discussing how MTV uses virt-v2v in migrations.
Preview: https://file.corp.redhat.com/rhoch/virt_v2v_mtv/html-single/#virt-v2v-mtv_mtv