Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTV-1433 UI plans by provider #585

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

MTV-1433 UI plans by provider #585

wants to merge 12 commits into from
+151 −149

Conversation

RichardHoch
Copy link
Collaborator

@RichardHoch RichardHoch commented Nov 14, 2024 •
edited
Loading

@RichardHoch RichardHoch changed the title UI plans by provider MTV-1433 UI plans by provider Nov 24, 2024
@RichardHoch RichardHoch mentioned this pull request Nov 27, 2024
Open
@RichardHoch
Copy link
Collaborator Author

@sgratch @mnecas Please review this PR.

fabiand
fabiand approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@fabiand fabiand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Textual changes lgtm.

For the reordering a preview with all pending PRs would be appreciated.

documentation/doc-Migration_Toolkit_for_Virtualization/master.adoc Show resolved Hide resolved
sgratch
sgratch reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@sgratch sgratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardHoch Few comments

documentation/doc-Migration_Toolkit_for_Virtualization/master.adoc Outdated
* {virt}

You can add a source provider by using the {ocp} web console.
* Remote {virt} clusters
Copy link
Contributor

@sgratch sgratch Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, migration can also be from a local ocp provider (to a remote one).
So a source OCP provider can be either local or remote.
@mnecas @fabiand please confirm

documentation/modules/creating-migration-plan-2-8.adoc Outdated

ifdef::vmware[]

. Check the following items related to VMware. All are optional except for *Warm migration*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following comments are relevant for all providers:

  1. "All are optional except for.." - WDYM by a non optional settings? It's a bit confusing since all options, including this setting, have a default value. So if not set by the user, a default cold value is used. A non optional setting is usually something that the user have to set for proceeding and include a red small asterisk next to it, e.g. plan name

  2. "Transfer Network" and "Target namepsace" settings are not detailed here. Is it in purpose?
    Screenshot from 2025-01-20 14-30-44

  3. Creating a plan via the plan wizard can be done also by going to Provider -> VMs tab, selecting VM(s) => and clicking the "Create migration plan" button. Is it mentioned anywhere?

@RichardHoch
Copy link
Collaborator Author

@sgratch I made the changes we talked about. Please review the PR again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgratch sgratch sgratch left review comments

@nunzy1 nunzy1 nunzy1 left review comments

@fabiand fabiand fabiand approved these changes

@mnecas mnecas Awaiting requested review from mnecas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RichardHoch @fabiand @nunzy1 @sgratch