-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs - Telemetry #66
Conversation
…okern link) Signed-off-by: idohu <[email protected]>
✅ Deploy Preview for kubescape-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@matthyx can you please look at this through your more knowledgable 👓 please? |
docs/docs/operator/telemetry.md
Outdated
insecure: <whether your otel endpoint requires ssl> | ||
headers: <optional - map of headers required by tracing tool> | ||
configurations: | ||
otelUrl: # default is empty ,add yours otel URL here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the English here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we should still include the endpoint
settings because it's required depending on which otel backend we're talking to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean ?
in capabillities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this configuration:
comment: opentelemetry collector
otelCollector:
name: otel-collector
endpoint:
insecure: true
headers:
uptrace-dsn: ""
comment: enable/disable hostmetrics collection
hostmetrics:
enabled: true
scrapeInterval: 30s
image:
repository: docker.io/otel/opentelemetry-collector
tag: 0.97.0
pullPolicy: IfNotPresent
resources:
requests:
cpu: 100m
memory: 500Mi
limits:
cpu: 1
memory: 1Gi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the endpoint
:
endpoint:
insecure: true
headers:
uptrace-dsn: ""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the user is configuring this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
he might need to, depending on which Otel endpoint he's using, for instance with uptrace https://uptrace.dev/get/get-started.html#resource-attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it is enough?
or to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the uptrace is all the configuration from this page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just merge it like that, it's fine
Signed-off-by: idohu <[email protected]>
Signed-off-by: idohu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
updated operator capabilities + fix telemetry page (updated config+broken link)