Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs - Telemetry #66

Merged
merged 3 commits into from
Jul 22, 2024
Merged

update docs - Telemetry #66

merged 3 commits into from
Jul 22, 2024

Conversation

idohuber
Copy link
Contributor

updated operator capabilities + fix telemetry page (updated config+broken link)

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for kubescape-io ready!

Name Link
🔨 Latest commit c3c7c59
🔍 Latest deploy log https://app.netlify.com/sites/kubescape-io/deploys/669e212f969a1e0008d2b6b7
😎 Deploy Preview https://deploy-preview-66--kubescape-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@idohuber idohuber requested a review from Oshratn July 15, 2024 15:15
@Oshratn
Copy link
Collaborator

Oshratn commented Jul 18, 2024

@matthyx can you please look at this through your more knowledgable 👓 please?

insecure: <whether your otel endpoint requires ssl>
headers: <optional - map of headers required by tracing tool>
configurations:
otelUrl: # default is empty ,add yours otel URL here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the English here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we should still include the endpoint settings because it's required depending on which otel backend we're talking to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean ?

in capabillities?

Copy link
Contributor Author

@idohuber idohuber Jul 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this configuration:
comment: opentelemetry collector
otelCollector:
name: otel-collector

endpoint:
insecure: true
headers:
uptrace-dsn: ""

comment: enable/disable hostmetrics collection
hostmetrics:
enabled: true
scrapeInterval: 30s

image:
repository: docker.io/otel/opentelemetry-collector
tag: 0.97.0
pullPolicy: IfNotPresent

resources:
requests:
cpu: 100m
memory: 500Mi
limits:
cpu: 1
memory: 1Gi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the endpoint:

endpoint:
  insecure: true
  headers:
  uptrace-dsn: ""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the user is configuring this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he might need to, depending on which Otel endpoint he's using, for instance with uptrace https://uptrace.dev/get/get-started.html#resource-attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it is enough?
or to add

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the uptrace is all the configuration from this page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just merge it like that, it's fine

idohuber added 2 commits July 21, 2024 10:33
Signed-off-by: idohu <[email protected]>
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@idohuber idohuber merged commit e54b197 into main Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants