Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): missing singular quote #49292

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(docs): missing singular quote #49292

wants to merge 3 commits into from

Conversation

MylesDev
Copy link

@MylesDev MylesDev commented Jan 6, 2025

Adds a missing ' to the 'array' OpenAPIv3 row, located in the "OpenAPIv3 and CEL type" table on https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/

@MylesDev
fix(docs): missing singular quote
87fe346 
Adds a missing ' to the 'array' OpenAPIv3 row, located in the "OpenAPIv3 and CEL type" table on https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 6, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @MylesDev!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 454cdd3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/677c0827061d0e00087018b2
😎 Deploy Preview https://deploy-preview-49292--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

@MylesDev Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

dipesh-rawat
dipesh-rawat reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

To re-trigger the EasyCLA bot check

@stmcginnis
Copy link
Contributor

Also, this is a pretty trivial edit (but good). If there are any other things on this page that you can find to clean up, that would be great to include it while you're at it.

@MylesDev
Copy link
Author

MylesDev commented Jan 6, 2025

Also, this is a pretty trivial edit (but good). If there are any other things on this page that you can find to clean up, that would be great to include it while you're at it.

Yes sure, I'll have a look to see if there's anything else.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 6, 2025
stmcginnis
stmcginnis reviewed Jan 6, 2025
View reviewed changes
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
@@ -1204,7 +1204,7 @@ Example Usage:

| CEL | Description |
|-----------------------------------------|-------------|
| `self.foo == "foo" || (oldSelf.hasValue() && oldSelf.value().foo != "foo")` | Ratcheted rule. Once a value is set to "foo", it must stay foo. But if it existed before the "foo" constraint was introduced, it may use any value |
| self.foo == "foo" || (oldSelf.hasValue() && oldSelf.value().foo != "foo")` | Ratcheted rule. Once a value is set to "foo", it must stay foo. But if it existed before the "foo" constraint was introduced, it may use any value |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. The closing backtick is after != "foo") and now the pipes will be interpreted as table column separators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@stmcginnis stmcginnis stmcginnis left review comments

@deads2k deads2k Awaiting requested review from deads2k

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MylesDev @k8s-ci-robot @dipesh-rawat @stmcginnis