Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding VolumeType for Azure for etcdMembers #17171

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Adding VolumeType for Azure for etcdMembers #17171

merged 1 commit into from
Jan 6, 2025
+20 −7

Conversation

ajgupta42
Copy link
Contributor

@ajgupta42 ajgupta42 commented Jan 6, 2025 •
edited by hakman
Loading

Fixes #16838

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 6, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Jan 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from zetaab January 6, 2025 08:25
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @ajgupta42!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ajgupta42. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 6, 2025
@ajgupta42
Copy link
Contributor Author

cc: @hakman

@hakman
Copy link
Member

hakman commented Jan 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025
@ajgupta42
Copy link
Contributor Author

ajgupta42 commented Jan 6, 2025 •
edited
Loading

fixing fmt

@ajgupta42
Copy link
Contributor Author

/retest-required

@ajgupta42
Copy link
Contributor Author

/retest

1 similar comment
@ajgupta42
Copy link
Contributor Author

/retest

hakman
hakman requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajgupta42. I added some small suggestions, if you don't mind.

upup/pkg/fi/cloudup/azuretasks/disk.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/disk.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/disk.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/disk_test.go Outdated Show resolved Hide resolved
pkg/model/master_volumes.go Outdated Show resolved Hide resolved
@ajgupta42
Copy link
Contributor Author

/retest

@ajgupta42
Copy link
Contributor Author

Thanks @hakman for the guidance, as it's my first commit in this repo

@ajgupta42 ajgupta42 requested a review from hakman January 6, 2025 14:08
@hakman
Copy link
Member

hakman commented Jan 6, 2025

Thanks @hakman for the guidance, as it's my first commit in this repo

Happy to help. Please also squash the commits.

@ajgupta42
Copy link
Contributor Author

@hakman Squashed

@ajgupta42
Copy link
Contributor Author

/retest

@hakman
Copy link
Member

hakman commented Jan 6, 2025

/test pull-kops-e2e-k8s-gce-ipalias

hakman
hakman approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ajgupta42!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit dee0e95 into kubernetes:master Jan 6, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jan 6, 2025
@hakman hakman mentioned this pull request Jan 6, 2025
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 6, 2025
@k8s-ci-robot
Merge pull request #17175 from hakman/automated-cherry-pick-of-#17171…
be747a6 
…-upstream-release-1.31

Automated cherry pick of #17171: Adding VolumeType for Azure for etcdMembers
@rifelpet rifelpet modified the milestones: v1.31, v1.32 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

[Azure] VolumeType is not working for Azure in etcdMembers
4 participants
@ajgupta42 @k8s-ci-robot @hakman @rifelpet