prow-build-trusted: Add PVC for publishing-bot #5685
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Prow PVCs | ||
| apiVersion: v1 | ||
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: publishing-bot-pvc | ||
| namespace: test-pods | ||
|
There was a problem hiding this comment. q: Is the same namespace in which all the prow test jobs run? |
||
| labels: | ||
| app: publisher | ||
| spec: | ||
| storageClassName: "premium-rwo" | ||
|
There was a problem hiding this comment. Is this same as |
||
| accessModes: | ||
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 100Gi | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: There can be cases where the contents stored in the publishing bot PV can get corrupted sometime and we will have to delete and recreate it.
Ref: https://github.com/kubernetes/publishing-bot/blob/master/production.md#what-is-the-persistent-volume-for
In such a scenario, how can someone easily delete and recreate the PVC ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the publishing-bot pod is handled by the prowjob, I suspect (I think I'm wrong) that for each run of the prowjob we'll get a new PV (or do we want to create the PV manually? ). If that's the case, cleanup can handled differently. One alternative could be the usage of ephemeral storage in the podSpec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. We dont to have a new PV for everyrun, that will defeat the purpose. The PV is used so that we dont have to download all the repos everytime. And ephemeral storage also wont suffice our needs. A PV is what we need, and whatever changes in this are good. I was thinking of methods on how to clean it incase if it gets corrupted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways, the cleanup part we can think of later in a separate PR once the publishing-bot is migrated to test-infra.
IMHO, for adding the PVC this is good. Thank you